-
Notifications
You must be signed in to change notification settings - Fork 104
Allow containers with a single variant #4853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4853-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3e323a4536ee9fa1ed482d30521c0a9f649acfe
# Push it to GitHub
git push --set-upstream origin backport-4853-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4853-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3e323a4536ee9fa1ed482d30521c0a9f649acfe
# Push it to GitHub
git push --set-upstream origin backport-4853-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
(cherry picked from commit c3e323a)
(cherry picked from commit c3e323a)
(cherry picked from commit c3e323a) Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit c3e323a) Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit c3e323a) # Conflicts: # output/schema/validation-errors.json
(cherry picked from commit c3e323a) # Conflicts: # output/schema/validation-errors.json
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
As discussed in #4796 (and offline with @Anaethelion and @swallez), it can make sense to allow single variants. This usually happens because the other variants are not exposed or have not been implemented yet.