Skip to content

Allow containers with a single variant #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 9, 2025

As discussed in #4796 (and offline with @Anaethelion and @swallez), it can make sense to allow single variants. This usually happens because the other variants are not exposed or have not been implemented yet.

@pquentin pquentin requested a review from a team as a code owner July 9, 2025 12:46
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit c3e323a into main Jul 10, 2025
17 of 18 checks passed
@pquentin pquentin deleted the containers-single-variant branch July 10, 2025 09:51
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4853-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3e323a4536ee9fa1ed482d30521c0a9f649acfe
# Push it to GitHub
git push --set-upstream origin backport-4853-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-4853-to-8.19.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4853-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3e323a4536ee9fa1ed482d30521c0a9f649acfe
# Push it to GitHub
git push --set-upstream origin backport-4853-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4853-to-8.18.

github-actions bot pushed a commit that referenced this pull request Jul 10, 2025
github-actions bot pushed a commit that referenced this pull request Jul 10, 2025
pquentin added a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit c3e323a)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit c3e323a)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit c3e323a)

# Conflicts:
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit c3e323a)

# Conflicts:
#	output/schema/validation-errors.json
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19
8.18

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit c3e323a)

# Conflicts:
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit c3e323a)

# Conflicts:
#	output/schema/validation-errors.json
@pquentin pquentin mentioned this pull request Jul 10, 2025
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants